-
-
Notifications
You must be signed in to change notification settings - Fork 862
Translations spring clean. #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.. _doc_ja: https://docs.python.org/ja/ | ||
.. _doc_ko: https://docs.python.org/ko/ | ||
.. _doc_pl: https://docs.python.org/pl/ | ||
.. _doc_zh_cn: https://docs.python.org/zh-cn/ | ||
.. _doc_zh_tw: https://docs.python.org/zh-tw/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They look too obvious to be mentionned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found them somewhat handy for two reasons:
- they show which translations have been already published;
- they provide an easy way to check the current published translation (instead of having to open d.p.o in a separate tab and selecting the language);
I think they might even deserve their own column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we turn the entry in the Language
column into a link to the docs when published?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
This has been moved to https://devguide.python.org/documentation/translating/ -- @JulienPalard do you want to update the PR, including the changes suggested in the review? |
There are also a few other improvements that can be done:
|
Is this PR still needed? @JulienPalard |
If @JulienPalard isn't assigned to this anymore, can I work on it (if you feel it's required)? |
Sure, @safwansamsudeen . Do you have a clear idea of what needs to be done here? It should be mostly mechanical in nature, but you'll need to (manually, but its mostly mechanical) integrate these changes with the latest version of the translations table (now in its own separate file), as well as make the requested changes (or at least the first two, the third might take a little more effort and could be done separately):
I suggest you start in a fresh branch as that's probably simpler for you at this point; @JulienPalard can be added as a co-author to the commit metadata if he's okay with that. We're happy to help further if you need additional guidance! |
How do I know which languages are published to see whether or not I should add the link? EDIT: also, how do I edit the table easily - there seems to require a lot of effort managing the spaces and |
You can tell what languages are published because they appear under the language selector on the docs homepage. The ones I see visible are these: Also, you can find the links to the GitHub repos for the various language under a filtered version of the Python org repository list.
Yeah, it can be quite tedious. I find it much easier in an editor (like Notepad++ on Windows, and many others) that offer a column mode and/or multi-line cursor features. You could also convert it to a list table which avoids this problem and is generally much easier to work with, but you'd want to make a separate PR converting the table to list-table syntax first with no changes, have that merged, and then manually re-make these changes in another PR on top of that, which would be a good deal more time and effort on your part. |
Several editors have an edit mode that makes editing tables easier by allowing you to edit and move columns, e.g. https://code.visualstudio.com/docs/getstarted/tips-and-tricks#_column-box-selection |
@CAM-Gerlach thanks for your help! I think converting into a list table would involve much more - IMO unproductive - effort. @ezio-melotti's solution sounds good, only I use IntelliJ, but I'll see. |
As mentionned in #896 some links were outdated.
Also keeping a link to an old initial email for a now mature translation with a repo and a presence on docs.python.org does not make sense.