Rewrite 'Regenerating configure' section of building guide #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
reviewed
Jun 8, 2023
hugovk
reviewed
Jun 8, 2023
erlend-aasland
commented
Jun 8, 2023
Use :cpy-file: role Put Docker and Podman commands in separate blocks Rewrite part about running the containers
|
Thanks for the reviews, Shantanu and Hugo! I made a small change post your approval, @hauntsaninja. You might want to take a look at it before I land this. |
CAM-Gerlach
changed the title
CAM-Gerlach
reviewed
Jun 9, 2023
There was a problem hiding this comment.
Standard reminder: You can directly apply all the suggestions you want in one go by going to Files changed -> Clicking Add to batch on each suggestion -> When done, clicking Commit
A number of minor tweaks and nitpicks, and one potentially non-trivial typo. Otherwise, LGTM
- link to GNU Autoconf - use modern terminology: pull request iso. patch - formatting: use default code-blocks - fix weird phrasing - fix aclocal name - as appropriate, not as is appropriate
hugovk
approved these changes
Jun 9, 2023
|
Thanks for the reviews everyone! 🙏🏻 |
|
Thanks for revising this all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of talking a lot about how to regenerate
configureusing GNU Autotools, first recommend what we really want people to do: usemake regen-configure. Second, mention that it's possible to run Christian's containers to regenerate configure. Lastly, talk briefly about regenerating using autotools directly. (IMO, we should remove that last bit; we just want people to use the containers.)📚 Documentation preview 📚: https://cpython-devguide--1109.org.readthedocs.build/