Skip to content

Revert "bpo-31356: Add context manager to temporarily disable GC #4224 #5495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Feb 2, 2018

This reverts commit 72a0d21.

The reverted commit had a few issues so it was unanimously decided
to undo it. See the bpo issue for details.

https://bugs.python.org/issue31356

…honGH-4224)"

This reverts commit 72a0d21.

The reverted commit had a few issues hene it was unanimously decided
to undo it. See the bpo issue for details.
@1st1 1st1 changed the title Revert "bpo-31356: Add context manager to temporarily disable GC (GH-… Revert "bpo-31356: Add context manager to temporarily disable GC #4224 Feb 2, 2018
@serhiy-storchaka
Copy link
Member

What about the NEWS entry? Should the existing entry be removed or a new entry about withdrawing the feature be added?

This is the only non-trivial part in this PR.

@1st1
Copy link
Member Author

1st1 commented Feb 2, 2018

@serhiy-storchaka Sure, makes sense.

@1st1
Copy link
Member Author

1st1 commented Feb 2, 2018

Added/removed a NEWS entry

@1st1 1st1 merged commit 383b32f into python:master Feb 2, 2018
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the revert branch February 2, 2018 14:31
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2018
…onGH-5495

This reverts commit 72a0d21.

The reverted commit had a few issues so it was unanimously decided
to undo it. See the bpo issue for details.
(cherry picked from commit 383b32f)

Co-authored-by: Yury Selivanov <yury@magic.io>
1st1 added a commit that referenced this pull request Feb 2, 2018
 (#5496)

This reverts commit 72a0d21.

The reverted commit had a few issues so it was unanimously decided
to undo it. See the bpo issue for details.
(cherry picked from commit 383b32f)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants