bpo-43390: Set SA_ONSTACK in PyOS_setsig #24730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is friendlier to other in-process code that an extension module or embedding use could pull in such as Cgo where tiny stacks are the norm and sigaltstack() has been used to provide for signal handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
SA_ONSTACKflag inPyOS_setsigfor the CPython VM'sdefault signal handlers. This is friendlier to other in-process code that an
extension module or embedding use could pull in (such as Golang's cgo) where
tiny thread stacks are the norm and
sigaltstack()has been used to provide forsignal handlers. This is a no-op change for the vast majority of processes
that don't use sigaltstack.
https://bugs.python.org/issue43390