move a dot outside double quotes #20007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deronnax
force-pushed
the
library_datetime_move_dot_outside_quotes
branch
from
f565553 to
483c225
Compare
|
LGTM, thanks @deronnax! |
|
Thanks @deronnax for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 17, 2020
(cherry picked from commit 4eba677) Co-authored-by: Mathieu Dupuy <mathieu.dupuy@doctolib.com>
|
GH-20160 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
May 17, 2020
(cherry picked from commit 4eba677) Co-authored-by: Mathieu Dupuy <mathieu.dupuy@doctolib.com>
|
Technically, I believe this change is grammatically incorrect even though it is something that I frequently use myself. It might be better to just avoid the situation with something like |
|
it's depressing but it looks @zware is right : https://www.thepunctuationguide.com/quotation-marks.html. |
deronnax
added a commit
to deronnax/cpython
that referenced
this pull request
May 18, 2020
This reverts commit 4eba677.
pganssle
pushed a commit
that referenced
this pull request
May 21, 2020
This is more informative and avoids the question of whether the period should go inside or outside the quotation marks. See also GH-20007.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2020
This is more informative and avoids the question of whether the period should go inside or outside the quotation marks. See also pythonGH-20007. (cherry picked from commit 2e76820) Co-authored-by: Mathieu Dupuy <mathieu.dupuy@doctolib.com>
This was referenced May 21, 2020
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2020
This is more informative and avoids the question of whether the period should go inside or outside the quotation marks. See also pythonGH-20007. (cherry picked from commit 2e76820) Co-authored-by: Mathieu Dupuy <mathieu.dupuy@doctolib.com>
miss-islington
added a commit
that referenced
this pull request
May 22, 2020
miss-islington
added a commit
that referenced
this pull request
May 22, 2020
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
This is more informative and avoids the question of whether the period should go inside or outside the quotation marks. See also pythonGH-20007.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the previous version of the sentence, the dot was rightly outside the quotes.