Skip to content

gh-132775: Use _PyCode GetScriptXIData() #134511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

gh-132775: Use _PyCode GetScriptXIData() #134511

merged 1 commit into from
May 22, 2025

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented May 22, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 22, 2025
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 22, 2025
Closed
@ericsnowcurrently ericsnowcurrently merged commit 09e72cf into python:main May 22, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@ericsnowcurrently ericsnowcurrently deleted the use-pycode-getscriptxidata branch May 22, 2025 14:40
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2025
@ericsnowcurrently @miss-islington
pythongh-132775: Use _PyCode GetScriptXIData() (pythongh-134511)
e576b24 
(cherry picked from commit 09e72cf)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 22, 2025

GH-134515 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 22, 2025
ericsnowcurrently added a commit that referenced this pull request May 22, 2025
@miss-islington @ericsnowcurrently
[3.14] gh-132775: Use _PyCode GetScriptXIData() (gh-134515)
bbf8048 
(cherry picked from commit 09e72cf, AKA gh-134511)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@encukou
Copy link
Member

encukou commented May 23, 2025

Since this was merged, NoGIL refleaks buildbots show refleaks: AMD64, M1

@ericsnowcurrently
Copy link
Member Author

See gh-134557.

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 23, 2025
@ericsnowcurrently
Revert "pythongh-132775: Use _PyCode GetScriptXIData() (pythongh-134511…
05fadc9 
…)"

This reverts commit 09e72cf.
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 23, 2025
Merged
ericsnowcurrently added a commit that referenced this pull request May 23, 2025
@ericsnowcurrently
gh-134557: Revert "gh-132775: Use _PyCode GetScriptXIData()" (gh-134599)
8a793c4 
This reverts commit 09e72cf, AKA gh-134511.

We are reverting due to refleaks on free-threaded builds.
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@ericsnowcurrently @lkollar
pythongh-132775: Use _PyCode GetScriptXIData() (pythongh-134511)
6d84fb3
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 26, 2025
Merged
ericsnowcurrently added a commit that referenced this pull request May 26, 2025
@ericsnowcurrently
gh-132775: Unrevert "Use _PyCode GetScriptXIData()" (gh-134735)
56743af 
This reverts commit 8a793c4, AKA gh-134599.

This effectively re-applies commit 09e72cf (gh-134511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsnowcurrently @encukou