gh-114177: avoid calling connection lost callbacks when loop is already closed in asyncio subprocess #134508
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
added
topic-asyncio
needs backport to 3.13
gvanrossum
reviewed
May 22, 2025
| @@ -104,7 +104,12 @@ def close(self): | |||
| for proto in self._pipes.values(): | |||
| if proto is None: | |||
| continue | |||
| proto.pipe.close() | |||
| # See https://github.com/python/cpython/issues/114177 | |||
There was a problem hiding this comment.
I think a gh-NNNNN reference is enough.
Suggested change
| # See https://github.com/python/cpython/issues/114177 | |
| # See gh-114177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the event loop is already closed, skip calling closing the pipe as it would otherwise lead to calling
connection_lostcallbacks which would error out of loop being closed.See issue for detailed analysis.
BaseSubprocessTransport.__del__fails if the event loop is already closed, which can leak an orphan process #114177