Skip to content

gh-131798: JIT: replace _LOAD_SMALL_INT with _LOAD_CONST_INLINE_BORROW #134406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented May 21, 2025

@Zheaoli Zheaoli requested a review from Fidget-Spinner as a code owner May 21, 2025 05:58
@Zheaoli Zheaoli changed the title gh-131798: JIT: replace _LOAD_SMALL_INT with _LOAD_SMALL_INT gh-131798: JIT: replace _LOAD_SMALL_INT with _LOAD_CONST_INLINE_BORROW May 21, 2025
`_LOAD_CONST_INLINE_BORROW`

Signed-off-by: Manjusaka <me@manjusaka.me>

add news

Signed-off-by: Manjusaka <me@manjusaka.me>

add tests

Signed-off-by: Manjusaka <me@manjusaka.me>

fix review idea

Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/const-small-int branch from d2741f1 to ee6e90b Compare May 21, 2025 08:12
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization! Just a couple of suggestions, then I can merge.

Zheaoli and others added 2 commits May 22, 2025 11:20
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli requested a review from brandtbucher May 22, 2025 03:24
@brandtbucher brandtbucher merged commit 8c5e555 into python:main May 22, 2025
54 checks passed
@Zheaoli Zheaoli deleted the manjusaka/const-small-int branch May 22, 2025 16:58
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants