GH-131798: Narrow types more aggressively in the JIT #134373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
performance
tomasr8
reviewed
May 20, 2025
Comment on lines
-568
to
-592
| case _POP_TOP_LOAD_CONST_INLINE: | ||
| case _POP_TOP_LOAD_CONST_INLINE_BORROW: | ||
| last->opcode = _NOP; | ||
| goto optimize_pop_top_again; | ||
| case _COPY: | ||
| case _LOAD_CONST_INLINE: | ||
| case _LOAD_CONST_INLINE_BORROW: | ||
| case _LOAD_FAST: | ||
| case _LOAD_FAST_BORROW: | ||
| case _LOAD_SMALL_INT: | ||
| last->opcode = _NOP; | ||
| if (opcode == _POP_TOP) { | ||
| opcode = buffer[pc].opcode = _NOP; | ||
| } | ||
| else if (opcode == _POP_TOP_LOAD_CONST_INLINE) { | ||
| opcode = buffer[pc].opcode = _LOAD_CONST_INLINE; | ||
| } | ||
| else if (opcode == _POP_TOP_LOAD_CONST_INLINE_BORROW) { | ||
| opcode = buffer[pc].opcode = _LOAD_CONST_INLINE_BORROW; | ||
| } | ||
| else { | ||
| assert(opcode == _POP_TWO_LOAD_CONST_INLINE_BORROW); | ||
| opcode = buffer[pc].opcode = _POP_TOP_LOAD_CONST_INLINE_BORROW; | ||
| goto optimize_pop_top_again; | ||
| } |
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the type version, we should also set the type (if possible). We can use this to narrow unknown classes to constants in uops like
_CHECK_ATTR_CLASS.(Also, fix a couple of cases where we were incorrectly detecting contradictions when updating some symbols.)