Skip to content

gh-133829: Update zipimport example to not mention Python 2.3 #133835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

gh-133829: Update zipimport example to not mention Python 2.3 #133835

wants to merge 12 commits into from
+12 −9

Conversation

sharktide
Copy link
Contributor

@sharktide sharktide commented May 10, 2025 •
edited by ZeroIntensity
Loading

#133829

Updates this zipimport example: https://docs.python.org/3.14/library/zipimport.html#examples which uses Python 2.3 to use 3.x and pip.pyz as the new example

This will close #133829

Ready for review

📚 Documentation preview 📚: https://cpython-previews--133835.org.readthedocs.build/en/133835/library/zipimport.html#examples

@bedevere-app bedevere-app bot mentioned this pull request May 10, 2025
Open
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels May 10, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 10, 2025
StanFromIreland
StanFromIreland reviewed May 10, 2025
View reviewed changes
@tomasr8 tomasr8 changed the title gh-133829 Update zipimport example to use pip.pyz gh-133829: Update zipimport example to use pip.pyz May 10, 2025
AA-Turner
AA-Turner requested changes May 10, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sharktide
Copy link
Contributor Author

I have made the requested changes; please review again.

@sharktide sharktide requested a review from sobolevn May 11, 2025 13:05
sobolevn
sobolevn reviewed May 11, 2025
View reviewed changes
@sharktide sharktide requested a review from sobolevn May 11, 2025 16:32
sobolevn
sobolevn reviewed May 11, 2025
View reviewed changes
@sharktide sharktide requested a review from sobolevn May 11, 2025 16:50
sobolevn
sobolevn reviewed May 11, 2025
View reviewed changes
sobolevn
sobolevn approved these changes May 11, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AA-Turner, what do you think?

StanFromIreland
StanFromIreland reviewed May 11, 2025
View reviewed changes
@sharktide @StanFromIreland
Update Doc/library/zipimport.rst
dc21001 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@sharktide

This comment was marked as resolved.

Sign in to view
@sharktide
Copy link
Contributor Author

@AA-Turner Please give final review

@sharktide sharktide changed the title gh-133829: Update zipimport example to use pip.pyz gh-133829: Update zipimport example to not be from Python 2 May 17, 2025
@sharktide
Copy link
Contributor Author

Someone please merge this since @AA-Turner isnt reviewing any time soon

@ZeroIntensity
Copy link
Member

Let's be patient! Adam will review when he gets a chance to do so. People are busy, and complaining doesn't get it landed any faster (though sometimes I wish it did 😉)

@sharktide
Copy link
Contributor Author

sharktide commented May 18, 2025 via email

ZeroIntensity
ZeroIntensity approved these changes May 18, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

@sharktide @ZeroIntensity
Update Doc/library/zipimport.rst
548857f 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@merwok merwok changed the title gh-133829: Update zipimport example to not be from Python 2 gh-133829: Update zipimport example to not mention Python 2.3 May 26, 2025
@sharktide
Copy link
Contributor Author

@AA-Turner Please give the final review when you get enough time next. Thank you!

@ZeroIntensity
Copy link
Member

Again, be patient. Spam pinging someone does not help their motivation to review. The devguide recommends waiting at least a month before tagging anyone.

@sharktide
Copy link
Contributor Author

I know, I just wanted to leave a nicer message than my last one, and I forgot about the edit button for a second

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adorilson adorilson adorilson left review comments

@StanFromIreland StanFromIreland StanFromIreland left review comments

@sobolevn sobolevn sobolevn approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees
No one assigned
Labels
awaiting merge docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update zipimport example (uses Python 2.3)
6 participants
@sharktide @AA-Turner @ZeroIntensity @adorilson @sobolevn @StanFromIreland