Skip to content

gh-131704: add PyComplex_FromString() and PyNumber_Complex() C-API functions #132347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

gh-131704: add PyComplex_FromString() and PyNumber_Complex() C-API functions #132347

wants to merge 4 commits into from
+288 −122

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Apr 10, 2025 •
edited
Loading

📚 Documentation preview 📚: https://cpython-previews--132347.org.readthedocs.build/

For reviewers:

  • it's a feature-complete pr, ready for review (but see issue thread)
  • I can split it on separate pr, per commits
  • nb_complex slot part is optional and might be implemented differently (i.e. without reusing reserved slot)

@bedevere-app bedevere-app bot mentioned this pull request Apr 10, 2025
Open
@skirpichev skirpichev force-pushed the add-missing-complexapi/131704 branch from 2ee9ccb to be76690 Compare April 10, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 will be requested when the pull request is marked ready for review kumaraditya303 is a code owner

@encukou encukou Awaiting requested review from encukou encukou will be requested when the pull request is marked ready for review encukou is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle will be requested when the pull request is marked ready for review pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin will be requested when the pull request is marked ready for review abalkin is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger will be requested when the pull request is marked ready for review rhettinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skirpichev