Skip to content

gh-111178: Fix function signatures for test_capi #131659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 24, 2025

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be consistent with the rest of your added code and the existing code (for *const *args). Btw, just check if you need to remove redundant casts for the affected functions.

vstinner and others added 2 commits March 24, 2025 14:33
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@vstinner
Copy link
Member Author

Just to be consistent with the rest of your added code and the existing code (for *const *args).

I applied your suggestions.

Btw, just check if you need to remove redundant casts for the affected functions.

Done: I checked all modified functions. There was no cast before.

@vstinner vstinner enabled auto-merge (squash) March 24, 2025 13:41
@vstinner vstinner merged commit 6226edc into python:main Mar 24, 2025
41 checks passed
@vstinner vstinner deleted the ubsan_test_capi branch March 24, 2025 14:04
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants