Skip to content

gh-111178: Fix function signatures in misc files #131180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Modules/_io/bufferedio.c
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,9 @@ _io__Buffered___sizeof___impl(buffered *self)
}

static int
buffered_traverse(buffered *self, visitproc visit, void *arg)
buffered_traverse(PyObject *op, visitproc visit, void *arg)
{
buffered *self = buffered_CAST(op);
Py_VISIT(Py_TYPE(self));
Py_VISIT(self->raw);
Py_VISIT(self->dict);
Expand Down Expand Up @@ -1481,8 +1482,9 @@ _io__Buffered_truncate_impl(buffered *self, PyTypeObject *cls, PyObject *pos)
}

static PyObject *
buffered_iternext(buffered *self)
buffered_iternext(PyObject *op)
{
buffered *self = buffered_CAST(op);
PyObject *line;
PyTypeObject *tp;

Expand Down
6 changes: 3 additions & 3 deletions Modules/_pickle.c
Original file line number Diff line number Diff line change
Expand Up @@ -7969,9 +7969,9 @@ pickle_clear(PyObject *m)
}

static void
pickle_free(PyObject *m)
pickle_free(void *m)
{
_Pickle_ClearState(_Pickle_GetState(m));
_Pickle_ClearState(_Pickle_GetState((PyObject*)m));
}

static int
Expand Down Expand Up @@ -8077,7 +8077,7 @@ static struct PyModuleDef _picklemodule = {
.m_slots = pickle_slots,
.m_traverse = pickle_traverse,
.m_clear = pickle_clear,
.m_free = (freefunc)pickle_free,
.m_free = pickle_free,
};

PyMODINIT_FUNC
Expand Down
5 changes: 3 additions & 2 deletions Modules/_threadmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -545,8 +545,9 @@ ThreadHandle_join(ThreadHandle *self, PyTime_t timeout_ns)
}

static int
set_done(ThreadHandle *handle)
set_done(void *arg)
{
ThreadHandle *handle = (ThreadHandle*)arg;
assert(get_thread_handle_state(handle) == THREAD_HANDLE_RUNNING);
if (detach_thread(handle) < 0) {
PyErr_SetString(ThreadError, "failed detaching handle");
Expand All @@ -564,7 +565,7 @@ ThreadHandle_set_done(ThreadHandle *self)
return -1;
}

if (_PyOnceFlag_CallOnce(&self->once, (_Py_once_fn_t *)set_done, self) ==
if (_PyOnceFlag_CallOnce(&self->once, set_done, self) ==
-1) {
return -1;
}
Expand Down
10 changes: 6 additions & 4 deletions Objects/typevarobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -2254,15 +2254,17 @@ call_typing_args_kwargs(const char *name, PyTypeObject *cls, PyObject *args, PyO
}

static PyObject *
generic_init_subclass(PyTypeObject *cls, PyObject *args, PyObject *kwargs)
generic_init_subclass(PyObject *cls, PyObject *args, PyObject *kwargs)
{
return call_typing_args_kwargs("_generic_init_subclass", cls, args, kwargs);
return call_typing_args_kwargs("_generic_init_subclass",
(PyTypeObject*)cls, args, kwargs);
}

static PyObject *
generic_class_getitem(PyTypeObject *cls, PyObject *args, PyObject *kwargs)
generic_class_getitem(PyObject *cls, PyObject *args, PyObject *kwargs)
{
return call_typing_args_kwargs("_generic_class_getitem", cls, args, kwargs);
return call_typing_args_kwargs("_generic_class_getitem",
(PyTypeObject*)cls, args, kwargs);
}

PyObject *
Expand Down
5 changes: 3 additions & 2 deletions Python/import.c
Original file line number Diff line number Diff line change
Expand Up @@ -1146,8 +1146,9 @@ get_cached_m_dict(struct extensions_cache_value *value,
}

static void
del_extensions_cache_value(struct extensions_cache_value *value)
del_extensions_cache_value(void *raw)
{
struct extensions_cache_value *value = raw;
if (value != NULL) {
del_cached_m_dict(value);
del_cached_def(value);
Expand Down Expand Up @@ -1248,7 +1249,7 @@ _extensions_cache_init(void)
hashtable_hash_str,
hashtable_compare_str,
hashtable_destroy_str, // key
(_Py_hashtable_destroy_func)del_extensions_cache_value, // value
del_extensions_cache_value, // value
&alloc
);
if (EXTENSIONS.hashtable == NULL) {
Expand Down
Loading