Skip to content

gh-130179: Fix some references leaks in _pickle #130180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2025
Merged

gh-130179: Fix some references leaks in _pickle #130180

merged 2 commits into from
Feb 16, 2025

Conversation

sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Feb 16, 2025 •
edited by bedevere-app bot
Loading

I found some possible memory leaks in _pickle. This PR fixes it.

@bedevere-app bedevere-app bot mentioned this pull request Feb 16, 2025
Closed
@sergey-miryanov
Copy link
Contributor Author

@serhiy-storchaka Please take a look. It seems related to your changes.

picnixz
picnixz approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it looks like an oversight.

sobolevn
sobolevn approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn
Copy link
Member

Refs #125752

@sobolevn sobolevn added the needs backport to 3.13 bugs and security fixes label Feb 16, 2025
@picnixz picnixz enabled auto-merge (squash) February 16, 2025 13:02
@picnixz picnixz disabled auto-merge February 16, 2025 13:03
@picnixz picnixz enabled auto-merge (squash) February 16, 2025 13:05
@picnixz
Copy link
Member

picnixz commented Feb 16, 2025 •
edited
Loading

(I disabled/enabled the auto-merge because I had a typo in the commit message and it's not possible to edit it after hitting the auto-merge button)

@picnixz
Copy link
Member

picnixz commented Feb 16, 2025

Oh the ARM build is failing with the usual network error. I'll re-disable the auto-merge just in case we need to re-update the PR later.

@picnixz picnixz disabled auto-merge February 16, 2025 13:09
serhiy-storchaka
serhiy-storchaka approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@sobolevn sobolevn merged commit e7f00cd into python:main Feb 16, 2025
41 checks passed
@miss-islington-app
Copy link

Thanks @sergey-miryanov for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
@sergey-miryanov @picnixz @miss-islington
pythongh-130179: Fix persistent_{id,load}_attr reference leaks in `…
3b5ddb2 
…_pickle` (pythonGH-130180)

(cherry picked from commit e7f00cd)

Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 16, 2025

GH-130190 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 16, 2025
sobolevn pushed a commit that referenced this pull request Feb 16, 2025
@miss-islington @sergey-miryanov @picnixz
[3.13] gh-130179: Fix persistent_{id,load}_attr reference leaks in …
2fcad2a 
…`_pickle` (GH-130180) (#130190)

gh-130179: Fix `persistent_{id,load}_attr` reference leaks in `_pickle` (GH-130180)
(cherry picked from commit e7f00cd)

Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@sobolevn sobolevn sobolevn approved these changes

@picnixz picnixz picnixz approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergey-miryanov @sobolevn @picnixz @serhiy-storchaka