gh-130141: clean up asyncio._SelectorTransport during __del__ #130142
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunixbochs
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
lunixbochs
force-pushed
the
gh-130141
branch
from
5734ddb to
d90b091
Compare
aligns the SelectorTransport __del__ implementation with force_close also sets sock_fd to -1 when closing the socket so stale fds can't be reused
lunixbochs
force-pushed
the
gh-130141
branch
from
d90b091 to
b5f4ce6
Compare
lunixbochs
changed the title
| self._sock = None | ||
|
|
||
| self._protocol = None | ||
| self._loop = None |
There was a problem hiding this comment.
What's the reason for setting loop to None?
There was a problem hiding this comment.
| self._loop._remove_writer(self._sock_fd) | ||
| self._conn_lost += 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_SelectorTransportunregisters fds it doesn't own #130141