Skip to content

Commit d6ac67f

Browse files
miss-islingtontiran
authored andcommitted
bpo-34001: Fix test_ssl with LibreSSL (GH-13783) (#15997)
(cherry picked from commit c9bc49c) Co-authored-by: Christian Heimes <christian@python.org>
1 parent c0acc0e commit d6ac67f

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Lib/test/test_ssl.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1106,6 +1106,7 @@ def test_hostname_checks_common_name(self):
11061106

11071107
@unittest.skipUnless(hasattr(ssl.SSLContext, 'minimum_version'),
11081108
"required OpenSSL 1.1.0g")
1109+
@unittest.skipIf(IS_LIBRESSL, "see bpo-34001")
11091110
def test_min_max_version(self):
11101111
ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER)
11111112
# OpenSSL default is MINIMUM_SUPPORTED, however some vendors like
@@ -3726,8 +3727,8 @@ def test_min_max_version(self):
37263727
self.assertEqual(s.version(), 'TLSv1.1')
37273728

37283729
# client 1.0, server 1.2 (mismatch)
3729-
server_context.minimum_version = ssl.TLSVersion.TLSv1_2
37303730
server_context.maximum_version = ssl.TLSVersion.TLSv1_2
3731+
server_context.minimum_version = ssl.TLSVersion.TLSv1_2
37313732
client_context.maximum_version = ssl.TLSVersion.TLSv1
37323733
client_context.maximum_version = ssl.TLSVersion.TLSv1
37333734
with ThreadedEchoServer(context=server_context) as server:
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Make test_ssl pass with LibreSSL. LibreSSL handles minimum and maximum TLS
2+
version differently than OpenSSL.

0 commit comments

Comments
 (0)