Skip to content

Commit c9bc49c

Browse files
tiranYhg1s
authored andcommitted
bpo-34001: Fix test_ssl with LibreSSL (GH-13783)
1 parent e24594b commit c9bc49c

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Lib/test/test_ssl.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1109,6 +1109,7 @@ def test_hostname_checks_common_name(self):
11091109

11101110
@unittest.skipUnless(hasattr(ssl.SSLContext, 'minimum_version'),
11111111
"required OpenSSL 1.1.0g")
1112+
@unittest.skipIf(IS_LIBRESSL, "see bpo-34001")
11121113
def test_min_max_version(self):
11131114
ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER)
11141115
# OpenSSL default is MINIMUM_SUPPORTED, however some vendors like
@@ -3731,8 +3732,8 @@ def test_min_max_version(self):
37313732
self.assertEqual(s.version(), 'TLSv1.1')
37323733

37333734
# client 1.0, server 1.2 (mismatch)
3734-
server_context.minimum_version = ssl.TLSVersion.TLSv1_2
37353735
server_context.maximum_version = ssl.TLSVersion.TLSv1_2
3736+
server_context.minimum_version = ssl.TLSVersion.TLSv1_2
37363737
client_context.maximum_version = ssl.TLSVersion.TLSv1
37373738
client_context.maximum_version = ssl.TLSVersion.TLSv1
37383739
with ThreadedEchoServer(context=server_context) as server:
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Make test_ssl pass with LibreSSL. LibreSSL handles minimum and maximum TLS
2+
version differently than OpenSSL.

0 commit comments

Comments
 (0)