-
Notifications
You must be signed in to change notification settings - Fork 54
Fix multiple typos #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e neck -> bottleneck and commited -> committed
Thanks a lot for taking the time to fix the typos. There are couple of things wrong with the pull request. The html files you fixes are generated automatically with sphinx from the Then, the commit adding the Buenos Aires sprint we already merged it's in this PR again. I think you probably created this branch from the previous instead of master. And if I'm not wrong we'll duplicate the event with the merge (it's strange that we don't get a conflict). Do you mind fixing the typos to the |
Not sure if any of the typos fixed in #39 where the ones you fixed here. Make sure you pull the latest code before making the changes in the |
Hi Marc, I made the changes in the First I had sphinx 1.6.6 and when it builds the pages they had many differences in format, in things like this: - background-color: #fff;
+ background-color: #ffffff;
...
-div.admonition tt.xref, div.admonition code.xref, div.admonition a tt {
- background-color: #FBFBFB;
+div.admonition tt.xref, div.admonition a tt {
border-bottom: 1px solid #fafafa;
} When I realized that this was a version problem, I tried to build with the same version that its built now, sphinx 1.7.0, and it worked well. It took me a while to find out that the differences came from a version problem. So it would be good to include in the guides the version of sphinx to use in the project, given that the default version to install with And , should I add the changes of #39 to Cheers |
Yep, we don't care that much on the sphinx version, and we keep changing these formatting depending on who sends the last pull request. Feel free to add any information you think can save people's time in the I don't quite get what you mean the changes where made in the
I think it'll be easier for you to send a new PR, but doesn't make a difference to me to approve this one if you update it, or reject this and approve another. Up to you. Thanks! |
Fixed typos in: - pandas/guide/pandas_setup.html
- pandas/guide/contents.html
- pandas/guide/organizers.html
- pandas/guide/pandas_docstring.html