add_text() on Paragraph #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks Evan :) I'll merge this in. On the .idea item in the .gitignore, that's probably best kept in your user-level gitignore (mine's at ~/.config/git/ignore). That way they stay out of all your Git projects and it keeps the project-level ignore file well focused :) |
|
Cool. I removed the .idea, as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone opened an issue for this a while ago, so I implemented it. This method allows you to easily add new text to the end of a paragraph and continue the style of the last run.
I experimented with some different ways to do it and came to the conclusion that the following behaviour is the most intuitive:
If you call add_text(t) on an empty paragraph, it adds a run with the given text and no style.
If you call add_text(t) on a non-empty paragraph, it adds the text to the last run, keeping the style of the last run.
The .idea in .gitignore is for PyCharm project files. Probably worth having it in there.