Skip to content

Remove ujson dependency and use python's json module #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove ujson dependency and use python's json module #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions pylsp/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,12 @@
# Copyright 2021- Python Language Server Contributors.

import argparse
import json
import logging
import logging.config
import sys
import time

try:
import ujson as json
except Exception: # pylint: disable=broad-except
import json

from .python_lsp import (
PythonLSPServer,
start_io_lang_server,
Expand Down
5 changes: 1 addition & 4 deletions pylsp/plugins/pylint_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

"""Linter plugin for pylint."""
import collections
import json
import logging
import sys
import re
Expand All @@ -13,10 +14,6 @@

from pylsp import hookimpl, lsp

try:
import ujson as json
except Exception: # pylint: disable=broad-except
import json

log = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion pylsp/python_lsp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
# Copyright 2021- Python Language Server Contributors.

from functools import partial
import json
import logging
import os
import socketserver
import threading
import uuid
from typing import List, Dict, Any
import ujson as json

from pylsp_jsonrpc.dispatchers import MethodDispatcher
from pylsp_jsonrpc.endpoint import Endpoint
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ dependencies = [
"jedi>=0.17.2,<0.20.0",
"pluggy>=1.0.0",
"python-lsp-jsonrpc>=1.1.0,<2.0.0",
"ujson>=3.0.0",
]
dynamic = ["version"]

Expand Down