Skip to content

Improve schema type compliance, improve CONFIGURATION.md #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

krassowski
Copy link
Member

  • Adds "item" to "array" types where missing
  • Adds "null" type where default null is used
  • Replace null with empty array ([]) where it made more sense (i.e. exclusion lists which are checked for truthiness rather than being None in the codebase)
  • Improve script generating CONFIGURATION.md:
    • support arrays of types
    • fix double whitespace instead of single whitespace when combining strings
    • fix missing enumeration of accepted values

@ccordoba12
Copy link
Member

Please rebase on top of the latest develop to get the fix to our tests in PR #231.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @krassowski!

@ccordoba12 ccordoba12 added this to the v1.5.0 milestone Jun 29, 2022
@ccordoba12 ccordoba12 merged commit 50841c1 into python-lsp:develop Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants