Skip to content

[pylint consider-using-any-or-all] Fix or disable all detected issues #12954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

The first commit is a small optimization, the second fix would have been opinionated so I disabled it locally in the second commit. (Had to recreate the MR from #12924

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nicoddemus nicoddemus added the skip news used on prs to opt out of the changelog requirement label Nov 12, 2024
@Pierre-Sassoulas Pierre-Sassoulas merged commit 76b8870 into pytest-dev:main Nov 12, 2024
29 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the pylint-optimization branch November 12, 2024 11:42
mwychung pushed a commit to mwychung/pytest that referenced this pull request Nov 14, 2024
…pytest-dev#12954)

* Avoid constructing a list of names
* noqa a a suggestion in already nested for
mwychung pushed a commit to mwychung/pytest that referenced this pull request Nov 15, 2024
…pytest-dev#12954)

* Avoid constructing a list of names
* noqa a a suggestion in already nested for
Glyphack pushed a commit to Glyphack/pytest that referenced this pull request Nov 23, 2024
…pytest-dev#12954)

* Avoid constructing a list of names
* noqa a a suggestion in already nested for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news used on prs to opt out of the changelog requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants