Skip to content

Fix compat with pytest 5.x #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2019
Merged

Fix compat with pytest 5.x #751

merged 1 commit into from
Jun 29, 2019

Conversation

rpkilby
Copy link
Contributor

@rpkilby rpkilby commented Jun 29, 2019

The following is preventing compatibility with the newly release pytest 5.0:

pytest.PytestDeprecationWarning: The `funcargnames` attribute was an alias for `fixturenames`, since pytest 2.3 - use the newer attribute instead.

@rpkilby
Copy link
Contributor Author

rpkilby commented Jun 29, 2019

Note that pytest 5.x has dropped py27 and py34 support, although, the related builds seem to be passing. I'm assuming that pytest-django is just not hitting those code paths where pytest would otherwise fail.

Eitherway, this should be safe to merge, since the changes have been deprecated since pytest 2.3

@blueyed
Copy link
Contributor

blueyed commented Jun 29, 2019

Note that pytest 5.x has dropped py27 and py34 support, although, the related builds seem to be passing. I'm assuming that pytest-django is just not hitting those code paths where pytest would otherwise fail.

It is using pytest 4.6 there.

@blueyed blueyed merged commit 3d23d5a into pytest-dev:master Jun 29, 2019
@rpkilby rpkilby deleted the pytest-5 branch June 30, 2019 23:05
mgaitan pushed a commit to EscrutinioSocial/escrutinio-social that referenced this pull request Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants