Rename test databases when running parallel Tox #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
=========================================
- Coverage 94.43% 94.34% -0.1%
=========================================
Files 33 33
Lines 1852 1857 +5
Branches 158 160 +2
=========================================
+ Hits 1749 1752 +3
- Misses 78 79 +1
- Partials 25 26 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
==========================================
- Coverage 98.06% 97.78% -0.28%
==========================================
Files 32 32
Lines 1862 1899 +37
Branches 147 150 +3
==========================================
+ Hits 1826 1857 +31
- Misses 24 27 +3
- Partials 12 15 +3
Continue to review full report at Codecov.
|
adamantike
force-pushed
the
tox-parallel-support
branch
2 times, most recently
from
7282d75 to
a6f355b
Compare
adamantike
changed the title
adamantike
added a commit
to adamantike/tox
that referenced
this pull request
Jan 14, 2019
To allow other libraries, or projects, to know if Tox is running in parallel mode, add the `TOX_PARALLEL_ENV` environment variable to the list of injected variables. Particularly, this is useful for `pytest-django` to know if Tox is running in parallel mode, to rename test databases [0]. [0] pytest-dev/pytest-django#680
adamantike
added a commit
to adamantike/tox
that referenced
this pull request
Jan 14, 2019
To allow other libraries, or projects, to know if Tox is running in parallel mode, add the `TOX_PARALLEL_ENV` environment variable to the list of injected variables. Particularly, this is useful for `pytest-django` to know if Tox is running in parallel mode, to rename test databases [0]. [0] pytest-dev/pytest-django#680
adamantike
force-pushed
the
tox-parallel-support
branch
from
a6f355b to
7e02ddf
Compare
adamantike
added a commit
to adamantike/tox
that referenced
this pull request
Jan 14, 2019
To allow other libraries, or projects, to know if Tox is running in parallel mode, add the `TOX_PARALLEL_ENV` environment variable to the list of injected variables. Particularly, this is useful for `pytest-django` to know if Tox is running in parallel mode, to rename test databases [0]. [0] pytest-dev/pytest-django#680
|
@blueyed updated to avoid removing the previous fixture, and avoided code duplication between the two new fixtures. This now depends on tox-dev/tox#1139 being merged, for the |
adamantike
added a commit
to adamantike/tox
that referenced
this pull request
Jan 15, 2019
To allow other libraries, or projects, to know if Tox is running in parallel mode, add the `TOX_PARALLEL_ENV` environment variable to the list of injected variables. Particularly, this is useful for `pytest-django` to know if Tox is running in parallel mode, to rename test databases [0]. [0] pytest-dev/pytest-django#680
adamantike
added a commit
to adamantike/tox
that referenced
this pull request
Jan 15, 2019
To allow other libraries, or projects, to know if Tox is running in parallel mode, add the `TOX_PARALLEL_ENV` environment variable to the list of injected variables. Particularly, this is useful for `pytest-django` to know if Tox is running in parallel mode, to rename test databases [0]. [0] pytest-dev/pytest-django#680
gaborbernat
pushed a commit
to tox-dev/tox
that referenced
this pull request
Jan 15, 2019
* Inject TOX_PARALLEL_ENV environment variables To allow other libraries, or projects, to know if Tox is running in parallel mode, add the `TOX_PARALLEL_ENV` environment variable to the list of injected variables. Particularly, this is useful for `pytest-django` to know if Tox is running in parallel mode, to rename test databases [0]. [0] pytest-dev/pytest-django#680 * Use strings (bytestrings in Python 2) in passenv whitelist
|
tox-dev/tox#1139 was merged for tox, so we can proceed here. |
|
Please rebase / fix coverage. |
adamantike
force-pushed
the
tox-parallel-support
branch
5 times, most recently
from
7123ee3 to
bbe5b8b
Compare
adamantike
force-pushed
the
tox-parallel-support
branch
3 times, most recently
from
5b73d1c to
0258e25
Compare
When tests are executed using Tox in parallel, modify the test database names, to avoid name collisions between processes. This change renames the existing `django_db_modify_db_settings_xdist_suffix` fixture, to a generic `django_db_modify_db_settings_parallel_suffix` one, in case more scenarios/tools have to be considered in the future. It also handles projects where both `pytest-xdist` and parallel `tox` are being using, generating database names like `test_default_py37-django21_gw0`. Resolves pytest-dev#678.
adamantike
force-pushed
the
tox-parallel-support
branch
from
0258e25 to
3da7437
Compare
|
@blueyed, rebased and improved coverage! There's only one line without coverage at the moment, which requires the database engine not to be Let me know how you'd like to proceed :) |
|
@blueyed bump! |
|
@adamantike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests are executed using Tox in parallel, modify the test database
names, to avoid name collisions between processes.
This change renames the existing
django_db_modify_db_settings_xdist_suffixfixture, to a genericdjango_db_modify_db_settings_parallel_suffixone, in case morescenarios/tools have to be considered in the future.
It also handles projects where both
pytest-xdistand paralleltoxare being using, generating database names like
test_default_py37-django21_gw0.This change is based on
toxnew parallel mode [0].Resolves #678.
[0] tox-dev/tox#1102