Fix building the docs on RTD #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we try merging this? |
|
Sure. |
mfa
pushed a commit
to aexeagmbh/pytest-django
that referenced
this pull request
May 17, 2017
timb07
pushed a commit
to timb07/pytest-django
that referenced
this pull request
May 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #449.
Side Note
I feel it's a bit odd to have a
requirements.txtfile in the root folder, which is - kind of - "pulled in by magic" (or by convention) by ReadTheDocs.Isn't
requirements.txt, when it exists in a package project's root folder, either referenced bysetup.pyfor installation or expected to be used manually for installation of the package or project?It's not all straight-forward. Also, now we have a dependency for building the docs in the root folder's requirements file. Odd. I think we should fix that.