Unexpected test order when mixing pytest / unittest tests and transactional tests

[pmourlanne]

Let's say I have the following tests:

import pytest
from django.test import TestCase, TransactionTestCase

@pytest.mark.django_db()
def test_function_with_db():
    ...

@pytest.mark.django_db(transaction=True)
def test_function_with_transactional_db():
    ...

class MyTestCase(TestCase):
    def test_method(self):
        ...

class MyTransactionTestCase(TransactionTestCase):
    def test_method(self):
        ...

I expect transactional tests, here test_function_with_transactional_db and MyTransactionTestCase.test_method to run last.

Running pytest yields:

$ pytest -v

prototype/test_prototype.py::test_function_with_db PASSED
prototype/test_prototype.py::test_function_with_transactional_db PASSED
prototype/test_prototype.py::MyTestCase::test_method PASSED
prototype/test_prototype.py::MyTransactionTestCase::test_method PASSED

I tried fixing this by adding a pytest_collection_modifyitems in my project but my custom ordering runs before pytest-django's ordering. So pytest-django gets the last word, and in this case it's not what I want :>

I think this can be fixed by improving on what's being done in pytest_collection_modifyitems, I'll try something out and hopefully open a PR.

[blueyed]

Does #820 (in master) fix it?

[blueyed]

Anyway, it might also just not work as expected.
The code that should take care of running it like Django is

pytest-django/pytest_django/plugin.py

Lines 419 to 440 in c65dc70

	def pytest_collection_modifyitems(items):
	def get_order_number(test):
	marker_db = test.get_closest_marker('django_db')
	if marker_db:
	transaction = validate_django_db(marker_db)[0]
	if transaction is True:
	return 1
	else:
	transaction = None
	fixtures = getattr(test, 'fixturenames', [])
	if "transactional_db" in fixtures:
	return 1
	if transaction is False:
	return 0
	if "db" in fixtures:
	return 0
	return 2
	items[:] = sorted(items, key=get_order_number)

.
(I've not investigated/looked closer at your report yet)

It likely needs to look at classes also then?

[pmourlanne]

I'll look at #820 👍

About the code yes, that's what I've been looking at, and yes it should look at classes if we want to change the behaviour :>
I've found this pytest-django-ordering plugin https://github.com/rlucioni/pytest-django-ordering/blob/master/pytest_django_ordering/plugin.py which kinda does what I want? I need to look a bit deeper into it.

Thank you for your quick answers :)

[pmourlanne]

#820 is going to make it so my custom ordering is applied after so yes, it should fix my current issue. I could also apply @pytest.hookimpl(trylast=True) to my project's pytest_collection_modifyitems.
This will be a fine workaround 👍

I still think pytest-django's behaviour could be improved, I'll keep digging for now :)