Made 0.21.1 compatible with pytest 8.2.0 #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unblocks all users stuck with 0.21.1 due to pytest-dev#706
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Apr 29, 2024
We cannot use pytest-async 0.23 because of pytest-dev/pytest-asyncio#706 We need to use pytest-async 0.23 if we use pytest 8.2 because of pytest-dev/pytest#12269 This may be fixed bt this backport of the fix in pytest-async 0.23: pytest-dev/pytest-asyncio#823
1 task
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
approved these changes
Apr 29, 2024
|
Is the plan to then make a 0.21.2 version that includes this change? |
|
Thank you @seifertm : I just updated a couple of repos to |
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Apr 30, 2024
We cannot use pytest-async 0.23 because of pytest-dev/pytest-asyncio#706 We need to use pytest-async 0.23 if we use pytest 8.2 because of pytest-dev/pytest#12269 This may be fixed bt this backport of the fix in pytest-async 0.23: pytest-dev/pytest-asyncio#823 Test MacOs using Python 3.8 becuase GHA no longer providing 3.7 on that platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported #800 to the 0.21.1 tag
This unblocks all users stuck with 0.21.1 due to #706
As is, this PR can't be merged. A new branch, created from tag 0.21.1, must be created first. Then the base branch of this PR must be changed to that branch
I've run a few test suites locally and these changes work fine: any feedback is welcome