Skip to content

Alternative yamlfmt settings #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2022
Merged

Alternative yamlfmt settings #254

merged 1 commit into from
Jan 13, 2022

Conversation

asvetlov
Copy link
Contributor

Default yamlfmt style is wider than I usually use.

The proposed PR suggests a much denser format.

@asvetlov
Copy link
Contributor Author

@Tinche @seifertm what do you think?
I can live with any auto-formatting, it is better than no formatting style at all.
But I think this version is slightly better readable (and looks like yaml formatting from GitHub docs).

@Tinche
Copy link
Member

Tinche commented Jan 13, 2022

Yeah, I can see how the original was too wide.

seifertm
seifertm approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the denser format is nicer to read. The new format is how I'd write it by hand.

@asvetlov asvetlov merged commit 4ee5722 into master Jan 13, 2022
@asvetlov asvetlov deleted the alternative-yamlfmt-setting branch January 13, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tinche Tinche Tinche approved these changes

@seifertm seifertm seifertm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asvetlov @Tinche @seifertm