Skip to content

Better MicroPython stdio for REPL #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

WebReflection
Copy link
Contributor

@WebReflection WebReflection commented Apr 4, 2024

This MR switches MicroPython stdio from linebuffer true to linebuffer false accordingly with Damien suggestion and tested already it makes the PyTerminal (REPL) work as expected.

This MR does the following:

  • it forces always linebuffer to false
  • it uses basically the exact same logic used internally in MicroPython to buffer the content and emit it as a whole once the end of line \n (char code 10) is passed along
  • it passes all tests for both output and errors

@WebReflection WebReflection force-pushed the better-micropython-stdio branch 4 times, most recently from 15d20c8 to f4a2f41 Compare April 4, 2024 11:30
@WebReflection WebReflection force-pushed the better-micropython-stdio branch from f4a2f41 to fa8a1a0 Compare April 4, 2024 11:35
@WebReflection WebReflection merged commit 9142384 into main Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant