Skip to content

add imports gotten from python files inspection #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

CJ-Wright
Copy link
Contributor

No description provided.

ctypes.macholib.dylib
ctypes.macholib.framework
ctypes.util
ctypes.wintypes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the original design was to add submodules like that. I'll defer that to @jackmaney.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can cut out the submodules if that is needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer that. If there is value in adding submodules we can discuss with @jackmaney and do that in another PR.

BTW, right now we use sphinx to create this list. It would be nice to add the import inspection you did here so we can re-do it when a new version is in. (Or issue a release with the same methodology for the older pythons.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was afraid you were going to ask for that 😉 I'll see what I can do, since I did it in a terminal session.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to do that now ;-p

@@ -326,6 +356,7 @@ xml.sax
xml.sax.handler
xml.sax.saxutils
xml.sax.xmlreader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out we did have some submodules in here. I wonder why those were included and the others weren't.

@ocefpaf ocefpaf merged commit 0759ace into pypi:master Nov 13, 2020
@CJ-Wright CJ-Wright deleted the python39_inspection branch November 13, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants