Skip to content

Fixes the unexpected implementation of the ModbusSerialClient.connected property #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Fixes the unexpected implementation of the ModbusSerialClient.connected property #2327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
303f04a
change semantic of connected property to just check if socket exists …
MAKOMO Sep 20, 2024
b18ed43
improve documentation of connected property
MAKOMO Sep 20, 2024
73b01d2
remove whitespaces
MAKOMO Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pymodbus/client/serial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,9 @@ def __init__( # pylint: disable=too-many-arguments
self.silent_interval = round(self.silent_interval, 6)

@property
def connected(self):
"""Connect internal."""
return self.connect()
def connected(self) -> bool:
"""Check if socket exists."""
return self.socket is not None

def connect(self) -> bool:
"""Connect to the modbus serial server."""
Expand Down
2 changes: 1 addition & 1 deletion pymodbus/client/tcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def __init__(

@property
def connected(self) -> bool:
"""Connect internal."""
"""Check if socket exists."""
return self.socket is not None

def connect(self):
Expand Down