Skip to content

Fix bug in slogdet and expose it in linalg module #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

theorashid
Copy link
Contributor

@theorashid theorashid commented Jun 6, 2024

…ype consistency

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94
Copy link
Member

Thanks! Can you add the example in the issue as a regression test?

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (36c55f5) to head (c45485f).
Report is 181 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   80.76%   80.83%   +0.07%     
==========================================
  Files         163      163              
  Lines       46941    46897      -44     
  Branches    11499    11468      -31     
==========================================
- Hits        37912    37910       -2     
+ Misses       6786     6774      -12     
+ Partials     2243     2213      -30     
Files with missing lines Coverage Δ
pytensor/tensor/nlinalg.py 95.22% <100.00%> (ø)

... and 8 files with indirect coverage changes

@ricardoV94 ricardoV94 changed the title np.linalg.slogdet to use np.array and expose Fix bug in nlinalg.slogdet and expose it in linalg module Jun 6, 2024
@ricardoV94 ricardoV94 added bug Something isn't working maintenance linalg Linear algebra labels Jun 6, 2024
@ricardoV94 ricardoV94 closed this Jun 6, 2024
@ricardoV94 ricardoV94 reopened this Jun 6, 2024
@ricardoV94 ricardoV94 merged commit 4b6a444 into pymc-devs:main Jun 6, 2024
59 of 60 checks passed
@ricardoV94 ricardoV94 changed the title Fix bug in nlinalg.slogdet and expose it in linalg module Fix bug in slogdet and expose it in linalg module Jun 6, 2024
@ricardoV94
Copy link
Member

Thanks @theorashid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linalg Linear algebra maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Slogdet returning floats instead of arrays
2 participants