-
Notifications
You must be signed in to change notification settings - Fork 134
Switched from miniconda-setup to micromamba-setup for mypy workflow #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@HangenYuu, any reason you closed this? I went on vacation right after you created this. I was hoping that @lucianopaz would be able to look at the BLAS flags error. |
I honestly did not know why too. I even deleted the branch. Let's me reopen it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HangenYuu, it looks like your installation isn't setting up the mamba command. Instead of erroring out there, the jobs seems to continue and pip install pytensor. Without mkl, the jobs terminates because it does not find blas ldflags.
You should change all calls to mamba
with micromamba
. I suggested the few I could here, but there are more in the yml job files.
@lucianopaz I made the changes and the tests seem to be passed already. Honestly did not expect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
==========================================
- Coverage 80.85% 80.84% -0.01%
==========================================
Files 162 163 +1
Lines 47012 46890 -122
Branches 11499 11468 -31
==========================================
- Hits 38010 37909 -101
- Misses 6748 6765 +17
+ Partials 2254 2216 -38 |
Description
Switch from using setup-miniconda to setup-micromamba in GitHub Actions for 3 current workflows
Related Issue
Checklist
Type of change