Skip to content

Switched from miniconda-setup to micromamba-setup for mypy workflow #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

HangenYuu
Copy link
Contributor

Description

Switch from using setup-miniconda to setup-micromamba in GitHub Actions for 3 current workflows

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@HangenYuu
Copy link
Contributor Author

HangenYuu commented May 25, 2024

mypy.yml works as expected. Moving on to other workflows 👍.

@HangenYuu
Copy link
Contributor Author

HangenYuu commented May 25, 2024

This is this PR current output of the tests:
image

image

I wonder whether I should set this config flag directly in test.yml and what should I set?

@ricardoV94
Copy link
Member

CC @maresb @lucianopaz

@HangenYuu HangenYuu closed this Jun 7, 2024
@HangenYuu HangenYuu deleted the micromamba_setup branch June 7, 2024 07:14
@maresb
Copy link
Contributor

maresb commented Jun 9, 2024

@HangenYuu, any reason you closed this? I went on vacation right after you created this. I was hoping that @lucianopaz would be able to look at the BLAS flags error.

@HangenYuu HangenYuu restored the micromamba_setup branch June 10, 2024 00:20
@HangenYuu HangenYuu reopened this Jun 10, 2024
@HangenYuu
Copy link
Contributor Author

I honestly did not know why too. I even deleted the branch. Let's me reopen it here.

Copy link
Member

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HangenYuu, it looks like your installation isn't setting up the mamba command. Instead of erroring out there, the jobs seems to continue and pip install pytensor. Without mkl, the jobs terminates because it does not find blas ldflags.

You should change all calls to mamba with micromamba. I suggested the few I could here, but there are more in the yml job files.

@HangenYuu
Copy link
Contributor Author

@lucianopaz I made the changes and the tests seem to be passed already. Honestly did not expect micromamba to be used instead of mamba, but that was just my assumption from using miniconda, which still uses conda to install package.

Copy link
Member

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twiecki twiecki merged commit 75a9fd2 into pymc-devs:main Jun 11, 2024
54 checks passed
@HangenYuu HangenYuu deleted the micromamba_setup branch June 17, 2024 12:58
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (863efc0) to head (1b52b0b).
Report is 217 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   80.85%   80.84%   -0.01%     
==========================================
  Files         162      163       +1     
  Lines       47012    46890     -122     
  Branches    11499    11468      -31     
==========================================
- Hits        38010    37909     -101     
- Misses       6748     6765      +17     
+ Partials     2254     2216      -38     

see 32 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants