Skip to content

Support int-like shapes in pt.full #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2024

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented May 9, 2024

Description

numpy.full supports int and the pytensor docs suggest full does as well. This brings the numpy expected behavior together

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (146a0a8) to head (256630d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #759   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files         162      162           
  Lines       46814    46816    +2     
  Branches    11453    11454    +1     
=======================================
+ Hits        37830    37832    +2     
  Misses       6735     6735           
  Partials     2249     2249           
Files Coverage Δ
pytensor/tensor/basic.py 88.26% <100.00%> (+0.01%) ⬆️

@williambdean
Copy link
Contributor Author

Changed up the test. Thanks for the feedback @ricardoV94
Let me know what you think

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@ricardoV94 ricardoV94 merged commit c9f5f65 into pymc-devs:main May 9, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: pt.full doesn't work with int shape
2 participants