Add matrix_transpose and .mT helpers
#702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Apr 10, 2024
ricardoV94
reviewed
Apr 10, 2024
11 tasks
ricardoV94
approved these changes
Apr 11, 2024
ricardoV94
reviewed
Apr 12, 2024
scripts/mypy-failing.txt
Outdated
| @@ -7,6 +7,7 @@ pytensor/compile/sharedvalue.py | |||
| pytensor/graph/rewriting/basic.py | |||
| pytensor/ifelse.py | |||
| pytensor/link/basic.py | |||
| pytensor/link/c/cmodule.py | |||
There was a problem hiding this comment.
I think you'll have to ignore this pre-commit failures locally until we figure out. On the CI it doesn't behave like in your local machine and these changes break it. You can add --no-verify when commiting from the terminal (or unselect run pre-commit hooks when commiting from pycharm).
Dhruvanshu-Joshi
force-pushed
the
matrix_trans
branch
from
0c7e087 to
a66aa22
Compare
ricardoV94
changed the title
matrix_transpose and .mT property helpers (#702)
ricardoV94
changed the title
matrix_transpose and .mT property helpers (#702)matrix_transpose and .mT property helpers
ricardoV94
changed the title
matrix_transpose and .mT property helpersmatrix_transpose and .mT helpers
|
Thanks @Dhruvanshu-Joshi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for
matrix_transposeoperation using pytensor. The function and the tests are similar to its numpy implementation.Also added a temporary fix for the mypy error.
Related Issue
Checklist
Type of change