Skip to content

Add script to downstream PRs. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 28, 2022
Merged

Add script to downstream PRs. #39

merged 9 commits into from
Nov 28, 2022

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented Nov 26, 2022

No description provided.

@ricardoV94 ricardoV94 requested a review from ferrine November 26, 2022 12:55
@ferrine
Copy link
Member

ferrine commented Nov 27, 2022

I think a more descriptive or message is needed, very hard to figure out what the or was about

ferrine
ferrine requested changes Nov 27, 2022
View reviewed changes
Copy link
Member

@ferrine ferrine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a more descriptive pr title

@twiecki twiecki requested a review from ferrine November 27, 2022 11:37
ferrine
ferrine reviewed Nov 27, 2022
View reviewed changes
Copy link
Member

@ferrine ferrine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant this informative title

curl https://api.github.com/repos/aesara-devs/aesara/pulls/1271 2>/dev/null | jq '.title'
"Implement multi-output Elemwise in Numba via guvectorize"

ferrine
ferrine reviewed Nov 27, 2022
View reviewed changes
twiecki and others added 2 commits November 27, 2022 22:20
@twiecki @ferrine
Update bin/downstream_pr.sh
6dd76e2 
Co-authored-by: Maxim Kochurov <maxim.v.kochurov@gmail.com>
@twiecki @ferrine
Update bin/downstream_pr.sh
b2fbbfe 
Co-authored-by: Maxim Kochurov <maxim.v.kochurov@gmail.com>
@ricardoV94 ricardoV94 merged commit 0181415 into pymc-devs:main Nov 28, 2022
@twiecki twiecki deleted the downstream_script branch November 28, 2022 11:12
@twiecki twiecki mentioned this pull request Nov 30, 2022
Merged
@ricardoV94 ricardoV94 added the aesara downstream PRs that were downstreamed from Aesara label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrine ferrine ferrine approved these changes

@ricardoV94 ricardoV94 ricardoV94 approved these changes

Assignees
No one assigned
Labels
aesara downstream PRs that were downstreamed from Aesara
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twiecki @ferrine @ricardoV94