Fix non-contiguous reshapes in numba backend #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.reshape(x, some_shape)
fails in numba if x is not contiguous. This can lead to compilation failures. We can work around this by converting to a contiguous array if it is not already the case. This is happening in code in dim_shuffle where the output shape is()
, so a valid input array will always be contiguous, but numba doesn't seem to realize this.Fixes pymc-devs/nutpie#40.
Checklist