XTensorVariable indexing update #1438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #1429 to support index assignment and increment
x[idx] = y
andx[idx] += y
, following xarray indexing and broadcasting semantics.As with regular TensorVariables, due to immutability/hashability constraints of PyTensor, it is not possible to use the python native operations, so one has to write
z = x[idx].set(y)
andz = x[idx].inc(y)
📚 Documentation preview 📚: https://pytensor--1438.org.readthedocs.build/en/1438/