-
Notifications
You must be signed in to change notification settings - Fork 131
Compute pushforward (Rop) via double application of pullback (Lop) and fix Scan and Max gradient bugs #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+583
−283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0836022
to
9221d2e
Compare
9e640a6
to
03e29d2
Compare
03e29d2
to
2798a6e
Compare
float32 tests fail, shocker... |
2798a6e
to
0b64124
Compare
a31d5a6
to
8031d33
Compare
8031d33
to
77e2581
Compare
Also fixes bug in Scan L_op and Max R_op Co-authored-by: Adrian Seyboldt <aseyboldt@users.noreply.github.com>
77e2581
to
4136161
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
+ Coverage 82.25% 82.28% +0.03%
==========================================
Files 186 186
Lines 47981 47987 +6
Branches 8630 8629 -1
==========================================
+ Hits 39465 39486 +21
+ Misses 6356 6347 -9
+ Partials 2160 2154 -6
🚀 New features to boost your workflow:
|
aseyboldt
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted this from #788 as it's a pretty nice feature to have. This should allow Rop of basically any graph, whereas the specialized support of Rop was pretty patchy.
Also fixes bugs in Scan L_op and Max R_op revealed by the changes / new tests.
Related to #182
Closes #6
Not using the new grad names yet on user facing functions and docs, let's do that for the next major release
📚 Documentation preview 📚: https://pytensor--1207.org.readthedocs.build/en/1207/