Match error message in function graph tests #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrine
commented
Dec 12, 2022
| FunctionGraph(var1, [var2]) | ||
|
|
||
| with pytest.raises(TypeError): | ||
| with pytest.raises(TypeError, match="'Variable' object is not reversible"): |
There was a problem hiding this comment.
This one end the above error message is slightly not clear to me. It did not refer to inputs or outputs
There was a problem hiding this comment.
Feel free to improve the error message
ricardoV94
approved these changes
Dec 12, 2022
ricardoV94
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 74.32% 74.41% +0.08%
==========================================
Files 177 179 +2
Lines 49078 49249 +171
Branches 10416 10422 +6
==========================================
+ Hits 36479 36649 +170
- Misses 10293 10295 +2
+ Partials 2306 2305 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for these changes
Function graph tests did not have clear error messages to check
Implementation details
Added
match=...to existingpytest.raisesChecklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance