Skip to content

Add the rosetta stone for PyMC and Stan notebook in docs/source/learn… #7786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Cocoden7
Copy link

@Cocoden7 Cocoden7 commented May 16, 2025

Description

Add the rosetta_stone_pymc_stan.ipynb (written by @ricardoV94) that discusses how models can be translated between PyMC and Stan in core_notebooks documentation's folder.

Related Issue

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7786.org.readthedocs.build/en/7786/

Copy link

welcome bot commented May 16, 2025

Thank You Banner]
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zaxtax
Copy link
Contributor

zaxtax commented May 17, 2025

I would add an authorship cell as well as a watermark cell to conform with how the other notebooks are written

@Cocoden7
Copy link
Author

I would add an authorship cell as well as a watermark cell to conform with how the other notebooks are written

I have added the authorship in the first cell. Thanks for your comment

@ricardoV94 ricardoV94 requested a review from OriolAbril May 25, 2025 14:05
@OriolAbril
Copy link
Member

I had not seen that yet, I think this should be an example notebook, not a core one. But I am happy to be convinced otherwise.


Full context:

At some point all notebooks were here in the main repo. This was problematic because they would only get updated with the library releases even though most notebooks are not related at all to the pymc releases, in fact, many didn't even run. After several failed attempts to try and keep notebooks re-executed as part of the release process plus the complains of people who added notebooks that worked with the latest release but were not available until the following release we decided to have example notebooks and library on different release/publishing schedules.

However, due to fast development, very close in time major versions and other reasons, we ended up with notebooks breaking very often, even key/core/vital/... notebooks like the getting started, glm overview, prior/posterior predictive... so to compensate a bit we chose to move back a handful of notebooks covering the core functionality of the library and have them be executed as part of the doc building process. This ensured those notebooks were always synced with the library releases; and as they were only a handful of fast-ish notebooks and not the whole over 100 examples gallery it was feasible.

Second however, at some point, automatic execution broke. It hasn't been fixed yet but it probably has an issue, and afaik, the idea it to fix that so core notebooks go back to sync with the library releases.

I personally think conceptually it is not a very good fit for the "core notebooks" concept, but I think this is arguable and as I said, I am happy to be convinced otherwise. If we merge that notebook though, fixing notebook execution would mean getting this to run on every commit and PR preview, so we'd need a working env on readthedocs with both pymc and stan properly installed and correctly available through the same ipython kernel. I would prefer not doing that, and if we decide that we don't plan to fix automatic execution then all notebooks (including this one) can go back to pymc-examples (and the ones we deem "core" can still be listed somewhere else in the "Learn" section).

@ricardoV94
Copy link
Member

On the location, I think it was @fonnesbeck who suggested it as a core notebook. I'm okay either way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants