Skip to content

Fix do/conditioning model docs #6936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented Sep 30, 2023 β€’

Closes #6935

  • Tested locally βœ…

πŸ“š Documentation preview πŸ“š: https://pymc--6936.org.readthedocs.build/en/6936/

@codecov
Copy link

codecov bot commented Sep 30, 2023 β€’

Codecov Report

Merging #6936 (0103e17) into main (e7965fd) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6936   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files         100      100           
  Lines       16853    16853           
=======================================
  Hits        15528    15528           
  Misses       1325     1325           
Files Coverage Ξ”
pymc/model/transform/conditioning.py 95.68% <ΓΈ> (ΓΈ)

@juanitorduz
Copy link
Contributor Author

@ricardoV94
Copy link
Member

"Model" is not showing a dropdown arrow:
image

Perhaps because it's centered around model/core.py?

@juanitorduz
Copy link
Contributor Author

@ricardoV94 I think I fixed it in ec9a874 Let me know what you think :)

@ricardoV94
Copy link
Member

Looks better but now there's a weird Model section under the outer Model drop down

@juanitorduz
Copy link
Contributor Author

juanitorduz commented Oct 1, 2023 β€’

Looks better but now there's a weird Model section under the outer Model drop down

Yeah ... but shall we re-name it as "Model Core"? I have not figure out how to remove it :(

@ricardoV94
Copy link
Member

I think we only need a section for "create and inspect model" which includes the stuff in "core"

@juanitorduz
Copy link
Contributor Author

ok 91d29ce removed the redundant section. WDYT?

@juanitorduz juanitorduz requested a review from twiecki October 1, 2023 19:28
@ricardoV94
Copy link
Member

We should have the Deterministics / Potential and set_data that used to be in Model/other in the model creation and inspection page.

Otherwise looks good to me

@juanitorduz
Copy link
Contributor Author

juanitorduz commented Oct 1, 2023 β€’

I think 0103e17 should do it :)

@ricardoV94
Copy link
Member

I think 0103e17 should do it :)

I just observed that it does :P

@ricardoV94 ricardoV94 merged commit 7c0a095 into pymc-devs:main Oct 2, 2023
@ricardoV94
Copy link
Member

Thanks @juanitorduz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put fgraph and conditioning model transforms inside model header in API Docs
3 participants