Skip to content

Update Aesara dependency #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 29, 2022
Merged

Update Aesara dependency #6336

merged 5 commits into from
Nov 29, 2022

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Nov 24, 2022 •
edited by ricardoV94
Loading

Another update to Aesara and aeppl.

I believe @aseyboldt and @ricardoV94 can add commits to fix the CI ?

Major / Breaking Changes

  • None

Bugfixes / New features

  • None

Docs / Maintenance

  • Updated to Aesara 2.8.8

@ricardoV94
Copy link
Member

No point in updating Aeppl dependency given #6334

@michaelosthege
Copy link
Member Author

No point in updating Aeppl dependency given #6334

I didn't know if there were going to be incompatibilities and updated just in case.

Do you have commits ready to cherry pick onto this branch to fix the CI ?

@michaelosthege michaelosthege added this to the v5.0.0 milestone Nov 24, 2022
@ricardoV94
Copy link
Member

No point in updating Aeppl dependency given #6334

I didn't know if there were going to be incompatibilities and updated just in case.

Do you have commits ready to cherry pick onto this branch to fix the CI ?

I am not sure I follow. I will push the fixes for that other PR and after that there is no Aeppl dependency anymore. So no point in updating it. Or were you asking something else?

@michaelosthege
Copy link
Member Author

I'm asking about the Aesara-induced failures here. You mentioned that there exists a branch with fixes?

@ricardoV94
Copy link
Member

Ah. One of the failures is addressed here: #6306

I'll have a look tomorrow

@michaelosthege michaelosthege force-pushed the aesara288 branch 2 times, most recently from bc970f1 to 003b805 Compare November 25, 2022 11:02
@codecov
Copy link

codecov bot commented Nov 25, 2022 •
edited
Loading

Codecov Report

Merging #6336 (c9c2430) into main (e0d25c8) will decrease coverage by 0.36%.
The diff coverage is 95.83%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6336      +/-   ##
==========================================
- Coverage   94.14%   93.78%   -0.37%     
==========================================
  Files         132      132              
  Lines       26714    26739      +25     
==========================================
- Hits        25150    25077      -73     
- Misses       1564     1662      +98
Impacted Files Coverage Δ
pymc/variational/updates.py 92.11% <ø> (ø)
pymc/backends/base.py 87.30% <66.66%> (-0.25%) ⬇️
pymc/model.py 89.62% <95.65%> (-0.14%) ⬇️
pymc/aesaraf.py 90.97% <100.00%> (-3.65%) ⬇️
pymc/math.py 70.04% <100.00%> (ø)
pymc/model_graph.py 80.00% <100.00%> (+1.17%) ⬆️
pymc/tests/distributions/test_truncated.py 99.48% <100.00%> (ø)
pymc/tests/variational/test_inference.py 99.03% <100.00%> (+<0.01%) ⬆️
pymc/data.py 47.96% <0.00%> (-32.12%) ⬇️
... and 2 more

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@michaelosthege
Copy link
Member Author

michaelosthege commented Nov 25, 2022 •
edited
Loading

I rebased onto the branch from #6334 to see if there will be more ToDos.

I can't change the base branch to the one from #6334 becase it's coming from Ricardo's fork...

Some tests are still failing. I suppose most of these are related to the new static shape handling.

Whoever does the next commit here should rebase on main. ✅

@michaelosthege
Copy link
Member Author

@aseyboldt unless I missed something, all remaining failures have something to do with unnamed variables and SpecifyShape. Is this related to your changes?

@ricardoV94 ricardoV94 changed the title Update Aesara and aeppl dependencies Update Aesara dependency Nov 27, 2022
@ricardoV94 ricardoV94 force-pushed the aesara288 branch 2 times, most recently from 4a6380c to 5371670 Compare November 28, 2022 15:35
@ricardoV94 ricardoV94 marked this pull request as ready for review November 28, 2022 17:39
@ricardoV94 ricardoV94 mentioned this pull request Nov 28, 2022
Closed
michaelosthege
michaelosthege commented Nov 28, 2022
View reviewed changes
Copy link
Member Author

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aseyboldt
Copy link
Member

Sorry, just saw this, but that commit was the one :-)
LGTM

@ricardoV94 ricardoV94 marked this pull request as draft November 29, 2022 09:11
@ricardoV94
Copy link
Member

Just one sec, cleaning a bit the create_value_var...

@michaelosthege @ricardoV94
Update Aesara to 2.8.8
c9c2430 
This includes several changes related to static shape handling.

`test_var_replacement` is marked XFAIL because of incompatibility
with the new static shape handling.
@ricardoV94 ricardoV94 marked this pull request as ready for review November 29, 2022 09:21
@ricardoV94 ricardoV94 mentioned this pull request Nov 29, 2022
Closed
@ricardoV94 ricardoV94 merged commit 3bbf8ee into pymc-devs:main Nov 29, 2022
@michaelosthege michaelosthege deleted the aesara288 branch November 29, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 ricardoV94 approved these changes

Assignees
No one assigned
Labels
maintenance pytensor
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelosthege @ricardoV94 @aseyboldt