Skip to content

Create value variable on transformed space #6306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Create value variable on transformed space #6306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions pymc/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,28 +1460,34 @@ def create_value_var(

"""
if value_var is None:
value_var = rv_var.type()
value_var.name = rv_var.name

if aesara.config.compute_test_value != "off":
value_var.tag.test_value = rv_var.tag.test_value

_add_future_warning_tag(value_var)
rv_var.tag.value_var = value_var
untransformed_value_var = rv_var.type()
untransformed_value_var.name = rv_var.name
else:
untransformed_value_var = value_var

# Make the value variable a transformed value variable,
# if there's an applicable transform
if transform is UNSET and rv_var.owner:
transform = _default_transform(rv_var.owner.op, rv_var)

if transform is not None and transform is not UNSET:
value_var = transform.forward(untransformed_value_var, *rv_var.owner.inputs).type()
value_var.name = f"{untransformed_value_var.name}_{transform.name}__"
value_var.tag.transform = transform
value_var.name = f"{value_var.name}_{transform.name}__"
if aesara.config.compute_test_value != "off":
value_var.tag.test_value = transform.forward(
value_var, *rv_var.owner.inputs
).tag.test_value
self.named_vars[value_var.name] = value_var
else:
value_var = untransformed_value_var

if aesara.config.compute_test_value != "off":
value_var.tag.test_value = rv_var.tag.test_value

_add_future_warning_tag(value_var)
rv_var.tag.value_var = value_var

self.rvs_to_transforms[rv_var] = transform
self.rvs_to_values[rv_var] = value_var
self.values_to_rvs[value_var] = rv_var
Expand Down