Add moments for KroneckerNormalDistribution

[anirudhacharya]

Moments and tests for KroneckerNormalDistribution

[codecov]

Codecov Report

Merging #5235 (76e6463) into main (36c7553) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5235      +/-   ##
==========================================
+ Coverage   79.01%   79.04%   +0.02%     
==========================================
  Files          87       87              
  Lines       14370    14376       +6     
==========================================
+ Hits        11354    11363       +9     
+ Misses       3016     3013       -3     

Impacted Files	Coverage Δ
pymc/distributions/multivariate.py	73.76% <100.00%> (+0.22%)	⬆️
pymc/parallel_sampling.py	87.33% <0.00%> (+1.00%)	⬆️

[anirudhacharya]

cc: @ricardoV94 for review.

[anirudhacharya]

@ricardoV94 is this PR good to go? The test failures in jax-sampling seem unrelated to this PR.

It is failing on test_sampling_jax.py::test_transform_samples and test_sampling_jax.py::test_get_log_likelihood with NotImplementedError

And the pre-commit is failing on some code formating issue, I think. Is there some specific pre-commit hook that you use? How do I make this pass?

[ricardoV94]

Is there some specific pre-commit hook that you use?

Yes, it's explained in here: https://docs.pymc.io/en/latest/contributing/python_style.html

[ricardoV94]

The failing tests are likely due to dependency versions that have been fixed in the main branch. If you rebase your PR on top of it, they should go away.

[mjhajharia]

lgtm, @ricardoV94 i saw this marked as done in #5078, can this be merged now?

[ricardoV94]

We need to rebase and rerun tests, as they were failing

[anirudhacharya]

Give me a couple of hours, I will rebase, run the tests and push the code.

…

On Mon, 3 Jan, 2022, 7:58 PM Ricardo Vieira, ***@***.***> wrote: We need to rebase and rerun tests, as they were failing — Reply to this email directly, view it on GitHub <#5235 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVGJZKKSMPX6RLZKWQJLDLUUGXBDANCNFSM5JHJYV3A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[mjhajharia]

no worries, i rebased it @anirudhacharya, the tests should pass now, thanks for contributing to PyMC!!!