adds beta-binomial mean and test cases #5175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5175 +/- ##
=======================================
Coverage 78.05% 78.05%
=======================================
Files 88 88
Lines 14146 14151 +5
=======================================
+ Hits 11042 11046 +4
- Misses 3104 3105 +1
|
51 tasks
ricardoV94
reviewed
Nov 13, 2021
…thod returns an integer value (rounding the mean down to the nearest integer) in this implementation
|
Seems like you picked some of the main commits by accident during your merge. Can you try to rebase to fix it? |
morganstrom
force-pushed
the
beta-binomial-moments
branch
from
b5ee33d to
2d8bf02
Compare
|
I don't know how that happened but I think I fixed it now! |
ricardoV94
approved these changes
Nov 13, 2021
|
Waiting to see if tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the get_moment method returns an integer value (rounding the mean down to the nearest integer) in this implementation. Probably due to multiplying an integer with floats..
This is made clear in two of the test cases, where np.floor is applied to the expected output. This is similar to the implementation of the Binomial mean (also a integer multiplied with a float, and where the test cases are also rounded to integer values) so I figured it would be OK. Let me know otherwise!
Thank your for opening a PR!
Depending on what your PR does, here are a few things you might want to address in the description: