Add back some missing moments #5147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
Codecov Report
@@ Coverage Diff @@
## main #5147 +/- ##
==========================================
+ Coverage 77.79% 77.80% +0.01%
==========================================
Files 88 88
Lines 14121 14145 +24
==========================================
+ Hits 10985 11006 +21
- Misses 3136 3139 +3
|
ricardoV94
requested changes
Nov 6, 2021
pymc/distributions/continuous.py
Outdated
| @@ -1399,6 +1405,12 @@ def dist(cls, lam, *args, **kwargs): | |||
| # Aesara exponential op is parametrized in terms of mu (1/lam) | |||
| return super().dist([at.inv(lam)], **kwargs) | |||
|
|
|||
| def get_moment(rv, size, lam): | |||
There was a problem hiding this comment.
We are converting lam to mu in the dist class method, so get_moment should expect mu already and you don't need to invert it (the same happens with the logcdf below).
That's why your tests are failing for the exponential.
There was a problem hiding this comment.
Ah that makes sense, thanks! I'll make that change.
ricardoV94
approved these changes
Nov 6, 2021
|
Thanks once again @michaeloriordan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add moments and tests for the below distributions as part of #5078