Add backports module and backport logp syntax #5083
Conversation
|
The compilation error in that test appeared on another PR a few days ago already. |
| @@ -13,6 +13,7 @@ jobs: | |||
| floatx: [float32, float64] | |||
| test-subset: | |||
| - | | |||
| --ignore=pymc3/tests/test_backports.py | |||
There was a problem hiding this comment.
Just curious why do we need to ignore it here? is it due to CI time?
There was a problem hiding this comment.
The first job in this matrix is the fall-back which runs all test files that aren't explicitly mentioned by the others.
It's complemented by the check_all_tests_are_covered.py pre-commit script checking that there's also no test file that's run by another job but not ignored here.
Pro-tip: On main you can run python scripts/check_all_tests_are_covered.py locally and it shows you which OS/floatX combination each test file is running in.
Co-authored-by: Ravin Kumar <ravinsdrive@gmail.com>
|
Thank you @michaelosthege |
I did not backport the other related functions (e.g. logcdf), but the backport of
pm.logp()alone should cover >90 % of the use cases.Closes #5052