Skip to content

Update test_extract_obs_data to test for AdvancedIncSubtensor #4869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Update test_extract_obs_data to test for AdvancedIncSubtensor #4869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2ee399
Update test_extract_obs_data to test for AdvancedIncSubtensor
brandonwillard Jul 19, 2021
fcab5b2
Update Op checks to include both AdvancedIncSubtensor Ops
brandonwillard Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pymc3/backends/arviz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

from aesara.graph.basic import Constant
from aesara.tensor.sharedvar import SharedVariable
from aesara.tensor.subtensor import AdvancedIncSubtensor
from aesara.tensor.subtensor import AdvancedIncSubtensor, AdvancedIncSubtensor1
from arviz import InferenceData, concat, rcParams
from arviz.data.base import CoordSpec, DimSpec
from arviz.data.base import dict_to_dataset as _dict_to_dataset
Expand Down Expand Up @@ -283,7 +283,7 @@ def log_likelihood_vals_point(self, point, var, log_like_fun):
point = {i.name: point[i.name] for i in log_like_fun.f.maker.inputs if i.name in point}
log_like_val = np.atleast_1d(log_like_fun(point))

if isinstance(var.owner.op, AdvancedIncSubtensor):
if isinstance(var.owner.op, (AdvancedIncSubtensor, AdvancedIncSubtensor1)):
try:
obs_data = extract_obs_data(var.tag.observations)
except TypeError:
Expand Down
4 changes: 2 additions & 2 deletions pymc3/tests/test_aesaraf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ def test_extract_obs_data():
constant = at.as_tensor(data_m.filled())
z_at = at.set_subtensor(constant[mask.nonzero()], missing_values)

assert isinstance(z_at.owner.op, AdvancedIncSubtensor)
assert isinstance(z_at.owner.op, (AdvancedIncSubtensor, AdvancedIncSubtensor1))

res = extract_obs_data(z_at)

Expand All @@ -360,7 +360,7 @@ def test_extract_obs_data():
constant = at.as_tensor(data_m.filled())
z_at = at.set_subtensor(constant[mask.nonzero()], missing_values)

assert isinstance(z_at.owner.op, AdvancedIncSubtensor1)
assert isinstance(z_at.owner.op, (AdvancedIncSubtensor, AdvancedIncSubtensor1))

res = extract_obs_data(z_at)

Expand Down
4 changes: 2 additions & 2 deletions pymc3/tests/test_idata_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import pandas as pd
import pytest

from aesara.tensor.subtensor import AdvancedIncSubtensor
from aesara.tensor.subtensor import AdvancedIncSubtensor, AdvancedIncSubtensor1
from arviz import InferenceData
from arviz.tests.helpers import check_multiple_attrs
from numpy import ma
Expand Down Expand Up @@ -327,7 +327,7 @@ def test_mv_missing_data_model(self):
inference_data = pm.sample(100, chains=2, return_inferencedata=True)

# make sure that data is really missing
assert isinstance(y.owner.op, AdvancedIncSubtensor)
assert isinstance(y.owner.op, (AdvancedIncSubtensor, AdvancedIncSubtensor1))

test_dict = {
"posterior": ["mu", "chol_cov"],
Expand Down