Skip to content

Use correct givens in Model.set_initval #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

brandonwillard
Copy link
Contributor

Closes #4737

@brandonwillard brandonwillard self-assigned this Jun 4, 2021
@brandonwillard brandonwillard linked an issue Jun 4, 2021 that may be closed by this pull request
@brandonwillard brandonwillard force-pushed the fix-initial-values-sampling branch 7 times, most recently from 3f50e69 to 280ac5b Compare June 5, 2021 00:10
@brandonwillard brandonwillard requested a review from ricardoV94 June 5, 2021 00:19
@brandonwillard brandonwillard force-pushed the fix-initial-values-sampling branch from 280ac5b to 18deecb Compare June 5, 2021 01:49
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonwillard brandonwillard merged commit 15088b8 into pymc-devs:v4 Jun 5, 2021
@brandonwillard brandonwillard deleted the fix-initial-values-sampling branch June 5, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with recent initval changes
2 participants